-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use JSON RPC for inbound tx observation (including blob tx in Decun upgrade) #1836
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1836 +/- ##
===========================================
+ Coverage 42.97% 44.80% +1.83%
===========================================
Files 217 218 +1
Lines 12792 12689 -103
===========================================
+ Hits 5497 5685 +188
+ Misses 6852 6553 -299
- Partials 443 451 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Wondering if we could consider testing it on local E2E test before moving to production.
…t-observe-blob-transaction
It's a good idea. I created a ticket for this as the 1st step: #1856 |
Description
Closes: 1755
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: